Reduce boilerplate for creating new testers [npm appveyor gem uptimerobot clojars]

package.json

@@ -111,6 +111,7 @@
     "babel-eslint": "^8.0.2",
     "babel-polyfill": "^6.26.0",
     "babel-preset-env": "^1.7.0",
+    "caller": "^1.0.1",
     "chai": "^4.1.2",
     "chai-as-promised": "^7.1.1",
     "chai-string": "^1.4.0",

services/librariesio/librariesio-dependent-repos.tester.js

@@ -4,11 +4,7 @@ const Joi = require('joi')
 const ServiceTester = require('../service-tester')
 const { isMetric } = require('../test-validators')
 
-const t = new ServiceTester({
-  id: 'librariesio-dependent-repos',
-  title: 'Libraries.io dependent repos',
-  pathPrefix: '/librariesio/dependent-repos',
-})
+const t = ServiceTester.forThisService()
 module.exports = t
 
 t.create('dependent repo count')

services/librariesio/librariesio-dependents.tester.js

@@ -4,11 +4,7 @@ const Joi = require('joi')
 const ServiceTester = require('../service-tester')
 const { isMetric } = require('../test-validators')
 
-const t = new ServiceTester({
-  id: 'librariesio-dependents',
-  title: 'Libraries.io dependents',
-  pathPrefix: '/librariesio/dependents',
-})
+const t = ServiceTester.forThisService()
 module.exports = t
 
 t.create('dependent count')

services/librariesio/librariesio-sourcerank.tester.js

@@ -4,11 +4,7 @@ const Joi = require('joi')
 const ServiceTester = require('../service-tester')
 const { anyInteger } = require('../validators')
 
-const t = new ServiceTester({
-  id: 'librariesio-sourcerank',
-  title: 'Libraries.io SourceRank',
-  pathPrefix: '/librariesio/sourcerank',
-})
+const t = ServiceTester.forThisService()
 module.exports = t
 
 t.create('sourcerank')

services/npm/npm-downloads.tester.js

@@ -0,0 +1,72 @@
+'use strict'
+
+const Joi = require('joi')
+const ServiceTester = require('../service-tester')
+const { isMetric } = require('../test-validators')
+const colorscheme = require('../../lib/colorscheme.json')
+const mapValues = require('lodash.mapvalues')
+
+const t = new ServiceTester({
+  id: 'NpmDownloads',
+  title: 'NpmDownloads',
+  pathPrefix: '/npm',
+})
+module.exports = t
+
+const colorsB = mapValues(colorscheme, 'colorB')
+
+t.create('total downloads of left-pad')
+  .get('/dt/left-pad.json?style=_shields_test')
+  .expectJSONTypes(
+    Joi.object().keys({
+      name: 'downloads',
+      value: isMetric,
+      colorB: colorsB.brightgreen,
+    })
+  )
+
+t.create('total downloads of @cycle/core')
+  .get('/dt/@cycle/core.json')
+  .expectJSONTypes(Joi.object().keys({ name: 'downloads', value: isMetric }))
+
+t.create('total downloads of package with zero downloads')
+  .get('/dt/package-no-downloads.json?style=_shields_test')
+  .intercept(nock =>
+    nock('https://api.npmjs.org')
+      .get('/downloads/range/1000-01-01:3000-01-01/package-no-downloads')
+      .reply(200, {
+        downloads: [{ downloads: 0, day: '2018-01-01' }],
+      })
+  )
+  .expectJSON({ name: 'downloads', value: '0', colorB: colorsB.red })
+
+t.create('exact total downloads value')
+  .get('/dt/exact-value.json')
+  .intercept(nock =>
+    nock('https://api.npmjs.org')
+      .get('/downloads/range/1000-01-01:3000-01-01/exact-value')
+      .reply(200, {
+        downloads: [
+          { downloads: 2, day: '2018-01-01' },
+          { downloads: 3, day: '2018-01-02' },
+        ],
+      })
+  )
+  .expectJSON({ name: 'downloads', value: '5' })
+
+t.create('total downloads when network is off')
+  .get('/dt/@cycle/core.json?style=_shields_test')
+  .networkOff()
+  .expectJSON({
+    name: 'downloads',
+    value: 'inaccessible',
+    colorB: colorsB.lightgray,
+  })
+
+t.create('total downloads of unknown package')
+  .get('/dt/npm-api-does-not-have-this-package.json?style=_shields_test')
+  .expectJSON({
+    name: 'downloads',
+    value: 'package not found or too new',
+    colorB: colorsB.red,
+  })

services/npm/npm-license.tester.js

@@ -0,0 +1,121 @@
+'use strict'
+
+const Joi = require('joi')
+const ServiceTester = require('../service-tester')
+const colorscheme = require('../../lib/colorscheme.json')
+const mapValues = require('lodash.mapvalues')
+
+const t = ServiceTester.forThisService()
+module.exports = t
+const colorsB = mapValues(colorscheme, 'colorB')
+
+t.create('gets the license of express')
+  .get('/express.json')
+  .expectJSONTypes(Joi.object().keys({ name: 'license', value: 'MIT' }))
+
+t.create('gets the license of express from a custom registry')
+  .get('/express.json?registry_uri=https://registry.npmjs.com')
+  .expectJSONTypes(Joi.object().keys({ name: 'license', value: 'MIT' }))
+
+t.create('public domain license')
+  .get('/redux-auth.json?style=_shields_test')
+  .expectJSON({ name: 'license', value: 'WTFPL', colorB: '#7cd958' })
+
+t.create('copyleft license')
+  .get('/trianglify.json?style=_shields_test')
+  .expectJSON({ name: 'license', value: 'GPL-3.0', colorB: colorsB.orange })
+
+t.create('permissive license')
+  .get('/express.json?style=_shields_test')
+  .expectJSON({ name: 'license', value: 'MIT', colorB: colorsB.green })
+
+t.create('permissive license for scoped package')
+  .get('/@cycle%2Fcore.json?style=_shields_test')
+  .expectJSON({ name: 'license', value: 'MIT', colorB: colorsB.green })
+
+t.create(
+  'permissive and copyleft licenses (SPDX license expression syntax version 2.0)'
+)
+  .get('/rho-cc-promise.json?style=_shields_test')
+  .expectJSON({
+    name: 'license',
+    value: '(MPL-2.0 OR MIT)',
+    colorB: colorsB.lightgrey,
+  })
+
+t.create('license for package without a license property')
+  .get('/package-without-license.json?style=_shields_test')
+  .intercept(nock =>
+    nock('https://registry.npmjs.org')
+      .get('/package-without-license/latest')
+      .reply(200, {
+        name: 'package-without-license',
+      })
+  )
+  .expectJSON({ name: 'license', value: 'missing', colorB: colorsB.red })
+
+t.create('license for package with a license object')
+  .get('/package-license-object.json?style=_shields_test')
+  .intercept(nock =>
+    nock('https://registry.npmjs.org')
+      .get('/package-license-object/latest')
+      .reply(200, {
+        name: 'package-license-object',
+        license: {
+          type: 'MIT',
+          url: 'https://www.opensource.org/licenses/mit-license.php',
+        },
+      })
+  )
+  .expectJSON({ name: 'license', value: 'MIT', colorB: colorsB.green })
+
+t.create('license for package with a license array')
+  .get('/package-license-array.json?style=_shields_test')
+  .intercept(nock =>
+    nock('https://registry.npmjs.org')
+      .get('/package-license-array/latest')
+      .reply(200, {
+        name: 'package-license-object',
+        license: ['MPL-2.0', 'MIT'],
+      })
+  )
+  .expectJSON({
+    name: 'license',
+    value: 'MPL-2.0, MIT',
+    colorB: colorsB.lightgrey,
+  })
+
+t.create('license for unknown package')
+  .get('/npm-registry-does-not-have-this-package.json?style=_shields_test')
+  .expectJSON({
+    name: 'license',
+    value: 'package not found',
+    colorB: colorsB.red,
+  })
+
+t.create('license when network is off')
+  .get('/pakage-network-off.json?style=_shields_test')
+  .networkOff()
+  .expectJSON({
+    name: 'license',
+    value: 'inaccessible',
+    colorB: colorsB.lightgrey,
+  })
+
+// This tests error-handling functionality in NpmBase.
+t.create('when json is malformed for scoped package')
+  .get('/@cycle%2Fcore.json')
+  .intercept(nock =>
+    nock('https://registry.npmjs.org')
+      .get('/@cycle%2Fcore')
+      .reply(200, {
+        'dist-tags': {
+          latest: '1.2.3',
+        },
+        versions: null,
+      })
+  )
+  .expectJSON({
+    name: 'license',
+    value: 'invalid json response',
+  })

services/npm/npm-type-definitions.tester.js

@@ -0,0 +1,33 @@
+'use strict'
+
+const Joi = require('joi')
+const ServiceTester = require('../service-tester')
+
+const t = ServiceTester.forThisService()
+module.exports = t
+
+const isTypeDefinition = Joi.string().regex(
+  /^((Flow|TypeScript)|(Flow \| TypeScript))$/
+)
+
+t.create('types (from dev dependencies + files)')
+  .get('/types/chalk.json')
+  .expectJSONTypes(
+    Joi.object().keys({ name: 'types', value: isTypeDefinition })
+  )
+
+t.create('types (from files)')
+  .get('/types/form-data-entries.json')
+  .expectJSONTypes(
+    Joi.object().keys({ name: 'types', value: isTypeDefinition })
+  )
+
+t.create('types (from types key)')
+  .get('/types/left-pad.json')
+  .expectJSONTypes(
+    Joi.object().keys({ name: 'types', value: isTypeDefinition })
+  )
+
+t.create('no types')
+  .get('/types/link-into.json')
+  .expectJSON({ name: 'types', value: 'none' })

services/npm/npm-version.tester.js

@@ -0,0 +1,55 @@
+'use strict'
+
+const Joi = require('joi')
+const ServiceTester = require('../service-tester')
+const { isSemver } = require('../test-validators')
+
+const t = ServiceTester.forThisService()
+module.exports = t
+
+t.create('gets the package version of left-pad')
+  .get('/left-pad.json')
+  .expectJSONTypes(Joi.object().keys({ name: 'npm', value: isSemver }))
+
+t.create('gets the package version of left-pad from a custom registry')
+  .get('/left-pad.json?registry_uri=https://registry.npmjs.com')
+  .expectJSONTypes(Joi.object().keys({ name: 'npm', value: isSemver }))
+
+t.create('gets the package version of @cycle/core')
+  .get('/@cycle/core.json')
+  .expectJSONTypes(Joi.object().keys({ name: 'npm', value: isSemver }))
+
+t.create('gets a tagged package version of npm')
+  .get('/npm/next.json')
+  .expectJSONTypes(Joi.object().keys({ name: 'npm@next', value: isSemver }))
+
+t.create('gets the correct tagged package version of npm')
+  .intercept(nock =>
+    nock('https://registry.npmjs.org')
+      .get('/-/package/npm/dist-tags')
+      .reply(200, { latest: '1.2.3', next: '4.5.6' })
+  )
+  .get('/npm/next.json')
+  .expectJSON({ name: 'npm@next', value: 'v4.5.6' })
+
+t.create('returns an error for version with an invalid tag')
+  .get('/npm/frodo.json')
+  .expectJSON({ name: 'npm', value: 'tag not found' })
+
+t.create('gets the package version of left-pad from a custom registry')
+  .get('/left-pad.json?registry_uri=https://registry.npmjs.com')
+  .expectJSONTypes(Joi.object().keys({ name: 'npm', value: isSemver }))
+
+t.create('gets the tagged package version of @cycle/core')
+  .get('/@cycle/core/canary.json')
+  .expectJSONTypes(Joi.object().keys({ name: 'npm@canary', value: isSemver }))
+
+t.create(
+  'gets the tagged package version of @cycle/core from a custom registry'
+)
+  .get('/@cycle/core/canary.json?registry_uri=https://registry.npmjs.com')
+  .expectJSONTypes(Joi.object().keys({ name: 'npm@canary', value: isSemver }))
+
+t.create('invalid package name')
+  .get('/frodo-is-not-a-package.json')
+  .expectJSON({ name: 'npm', value: 'package not found' })