Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce boilerplate in a few more service testers [cdnjs continuousphp node shippable wercker gem] #1957

Merged
merged 7 commits into from
Aug 27, 2018

Conversation

paulmelnikow
Copy link
Member

Follow up to #1934.

@paulmelnikow paulmelnikow added the service-badge Accepted and actionable changes, features, and bugs label Aug 23, 2018
@shields-ci
Copy link

Messages
📖

✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS

@chris48s
Copy link
Member

Looks good 👍

It looks like NPM downloads and Gem downloads also got overlooked in #1934 for some reason:

const t = new ServiceTester({
id: 'gem-downloads',
title: 'Ruby Gem Downloads',
pathPrefix: '/gem',
})
module.exports = t

const t = new ServiceTester({
id: 'NpmDownloads',
title: 'NpmDownloads',
pathPrefix: '/npm',
})
module.exports = t

was that oversight, or is there something we're waiting on for those? (like with APM)

@paulmelnikow paulmelnikow changed the title Reduce boilerplate in a few more service testers [cdnjs continuousphp node shippable wercker] Reduce boilerplate in a few more service testers [cdnjs continuousphp node shippable wercker gem] Aug 23, 2018
@paulmelnikow
Copy link
Member Author

I thought I responded to this comment, though I don't see it now. 🤔

I updated gem-downloads. npm-downloads can't be handled using this shortcut, because that module exposes four separate services.

This should be good to merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants