[elm-package] Fix elm package service

[j-maas]

With the release of Elm 0.19.0, the package file changed (from elm-package.json to elm.json), which breaks the badge.

(This replaces #1979 due to a refactor.)

[shields-ci]

	Messages
📖	✨ Thanks for your contribution to Shields, @y0hy0h!

Generated by 🚫 dangerJS

[j-maas]

Is it possible to use the https version here?

[paulmelnikow]

Yes, if that is supported, that would be great!

[j-maas]

The https URL is online, but I don't know if shields handles it. I guess I'll just change this, since I have to trigger the tests anyway.

[paulmelnikow]

The CI failed initially because I told you the wrong tag. The format just changed and I'm still getting the hang of it!

Added: Despite the green check mark, the service tests have not run. (Ref #1936) @y0hy0h If you push a new commit with the scheme change, hopefully they will run then. 🤞

[j-maas]

There still seems to be an issue with the service name.

[paulmelnikow]

Argh, I guess I had that title format right to begin with.

When I run the tests locally using npm run test:services -- --only=elm-package, I get these two failures. It looks like the tests need to be updated to reflect the formatting change.

  1) ELM PACKAGE
       gets the package version of elm-lang/core

	[ GET /v/elm-lang/core.json ]:
     ValidationError: child "name" fails because ["name" must be one of [elm-package]]
      at Object.exports.process (node_modules/joi/lib/errors.js:196:19)
      at internals.Object._validateWithOptions (node_modules/joi/lib/types/any/index.js:675:31)
      at module.exports.internals.Any.root.validate (node_modules/joi/lib/index.js:138:23)
      at Object.pathMatch.matchJSONTypes (node_modules/icedfrisby/lib/pathMatch.js:303:9)
      at _expect (node_modules/icedfrisby/lib/icedfrisby.js:563:10)
      at IcedFrisbyNock._invokeExpects (node_modules/icedfrisby/lib/icedfrisby.js:1261:26)
      at start (node_modules/icedfrisby/lib/icedfrisby.js:1244:12)
      at Request.runCallback [as _callback] (node_modules/icedfrisby/lib/icedfrisby.js:1131:16)
      at Request.self.callback (node_modules/request/request.js:185:22)
      at Request.EventEmitter.emit (domain.js:442:20)
      at Request.<anonymous> (node_modules/request/request.js:1161:10)
      at Request.EventEmitter.emit (domain.js:442:20)
      at IncomingMessage.<anonymous> (node_modules/request/request.js:1083:12)
      at IncomingMessage.EventEmitter.emit (domain.js:442:20)
      at endReadableNT (_stream_readable.js:1081:12)
      at process._tickCallback (internal/process/next_tick.js:63:19)

  2) ELM PACKAGE
       invalid package name

	[ GET /v/elm-community/frodo-is-not-a-package.json ]:

      AssertionError: expected { Object (name, value) } to deeply equal { Object (name, value) }
      + expected - actual

       {
      -  "name": "elm package"
      +  "name": "elm-package"
         "value": "invalid"
       }

      at Object.pathMatch.matchJSON (node_modules/icedfrisby/lib/pathMatch.js:138:38)
      at _expect (node_modules/icedfrisby/lib/icedfrisby.js:583:10)
      at IcedFrisbyNock._invokeExpects (node_modules/icedfrisby/lib/icedfrisby.js:1261:26)
      at start (node_modules/icedfrisby/lib/icedfrisby.js:1244:12)
      at Request.runCallback [as _callback] (node_modules/icedfrisby/lib/icedfrisby.js:1131:16)
      at Request.self.callback (node_modules/request/request.js:185:22)
      at Request.EventEmitter.emit (domain.js:442:20)
      at Request.<anonymous> (node_modules/request/request.js:1161:10)
      at Request.EventEmitter.emit (domain.js:442:20)
      at IncomingMessage.<anonymous> (node_modules/request/request.js:1083:12)
      at IncomingMessage.EventEmitter.emit (domain.js:442:20)
      at endReadableNT (_stream_readable.js:1081:12)
      at process._tickCallback (internal/process/next_tick.js:63:19)

[j-maas]

The tests are passing now. However, I'm not entirely sure on the following naming inconsistency:

The service is called elm-package, but the badge will display elm package (and internally some fields will be named the latter). I don't know if it is even possible to rename the service to elm package (because of the whitespace).
I guess this depends on whether there is a guideline for this sort of naming issue. I personally think it's ok, but it's not perfect.

Is there a simple fix to this I'm not seeing?

[paulmelnikow]

The ID is only used for running the test. This looks great! Thank you!

[shields-deployment]

This pull request was merged to master branch. Now this change is waiting for deployment.
Deploys usually happen every few weeks. After deployment changes are copied to gh-pages branch.

This badge displays deployment status: