Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use most permissive license color #2196

Merged
merged 4 commits into from
Oct 20, 2018
Merged

Conversation

pnowaczyk
Copy link
Contributor

Hello, I'd like to propose a solution for a TODO left in lib/licenses.js 😄
I think that since something is available under many licenses, it can be obtained under the most permissive one, thus we can set the badge color to that specific one.
What do you think? I'm open for discussion 😃

@shields-ci
Copy link

Messages
📖

✨ Thanks for your contribution to Shields, @pnowaczyk!

Generated by 🚫 dangerJS

@PyvesB PyvesB added the service-badge Accepted and actionable changes, features, and bugs label Oct 20, 2018
Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for looking into this @pnowaczyk! This approach seems good to me. 👍

@platan platan closed this Oct 20, 2018
@platan platan reopened this Oct 20, 2018
@platan
Copy link
Member

platan commented Oct 20, 2018

I closed and reopened this PR because WIP check hung. But it did not help at all.

@pnowaczyk
Copy link
Contributor Author

Any way I can help with that?

@platan platan changed the title use most permissive license color use most permissive license color. Oct 20, 2018
@platan platan changed the title use most permissive license color. use most permissive license color Oct 20, 2018
@platan platan merged commit 4554f49 into badges:master Oct 20, 2018
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@platan
Copy link
Member

platan commented Oct 20, 2018

I changed PR title and it helped :-)
@chris48s @PyvesB have you noticed any problems with the WIP check before?

@chris48s
Copy link
Member

@platan I've seen this problem a few times. This PR for example: #2200 (unless we've changed something before you read this). I had a couple of dependabot PRs incorrectly stuck on WIP as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants