-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use most permissive license color #2196
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
PyvesB
added
the
service-badge
Accepted and actionable changes, features, and bugs
label
Oct 20, 2018
PyvesB
approved these changes
Oct 20, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for looking into this @pnowaczyk! This approach seems good to me. 👍
platan
approved these changes
Oct 20, 2018
I closed and reopened this PR because WIP check hung. But it did not help at all. |
Any way I can help with that? |
platan
changed the title
use most permissive license color
use most permissive license color.
Oct 20, 2018
platan
changed the title
use most permissive license color.
use most permissive license color
Oct 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I'd like to propose a solution for a TODO left in
lib/licenses.js
😄I think that since something is available under many licenses, it can be obtained under the most permissive one, thus we can set the badge color to that specific one.
What do you think? I'm open for discussion 😃