Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage cleanup #2328

Merged
merged 5 commits into from
Nov 17, 2018
Merged

Coverage cleanup #2328

merged 5 commits into from
Nov 17, 2018

Conversation

paulmelnikow
Copy link
Member

  • Stop running daily service tests in the main repo (since they're now handled over here
  • Add coverage and separate daily tests badges with links to coveralls
  • Update our coverage ignores
    • Move scripts, which do not need coverage, into scripts/
  • Split out coverage test for npm package
  • Remove spurious env var

Ref: #1584 #2314

@paulmelnikow paulmelnikow added the developer-experience Dev tooling, test framework, and CI label Nov 16, 2018
@shields-ci
Copy link

Warnings
⚠️ This PR modified `package.json`, but not `package-lock.json` - Perhaps you need to run `npm install`?
Messages
📖 ✨ Thanks for your contribution to Shields, @paulmelnikow!
📖 Thanks for contributing to our documentation. We ❤️ our [documentarians](http://www.writethedocs.org/)!

Generated by 🚫 dangerJS

@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-2328 November 16, 2018 04:31 Inactive
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@paulmelnikow paulmelnikow deleted the coverage-cleanup branch November 17, 2018 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer-experience Dev tooling, test framework, and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants