Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move remaining badge examples into services/ [cpan] #2349

Merged
merged 9 commits into from
Nov 19, 2018
Merged

Move remaining badge examples into services/ [cpan] #2349

merged 9 commits into from
Nov 19, 2018

Conversation

paulmelnikow
Copy link
Member

@paulmelnikow paulmelnikow commented Nov 17, 2018 •
edited
Loading

Except NuGet; leaving those for the last pass.

Blocks work on the NuGet badges, blocks refactoring prepareExamples, and conflicts with potential work on any of these services.

Nexus failures are unrelated (#2347), so skipping those.

@paulmelnikow
Move remaining badge examples into services/ [cpan]
576f053 
Except NuGet; leaving those for the last pass.
@paulmelnikow paulmelnikow added service-badge Accepted and actionable changes, features, and bugs blocker PRs and epics which block other work labels Nov 17, 2018
@shields-ci
Copy link

Warnings
⚠️ This PR modified service code for amo but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for cran but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for crates but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for dub but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for hackage but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for chrome-web-store but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for packagist but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for puppetforge but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for redmine but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for stackexchange but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for vaadin-directory but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for bower but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for vscode-marketplace but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for luarocks but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @paulmelnikow!
📖 Thanks for contributing to our documentation. We ❤️ our [documentarians](http://www.writethedocs.org/)!

Generated by 🚫 dangerJS

@paulmelnikow paulmelnikow changed the title Move remaining badge examples into services/ [cpan] Move remaining badge examples into services/ [cpan nexus] Nov 17, 2018
@paulmelnikow paulmelnikow changed the title Move remaining badge examples into services/ [cpan nexus] Move remaining badge examples into services/ [cpan] Nov 17, 2018
@chris48s
Copy link
Member

I haven't done a proper review on this because there's an example somewhere which is throwing

Parameter 'url' must be a string, not undefined

on the version category or any search which is making it difficult to check. Can you have a look at that one first and I'll come back and look at this in more detail. Cheers

@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-2349 November 18, 2018 18:28 Inactive
@paulmelnikow
Copy link
Member Author

Fixed in e685868. The problem was in one of the examples left in all-badge-examples. We're already validating in BaseService and soon that won't have explicit examples, so this is basically one-off.

chris48s
chris48s reviewed Nov 18, 2018
View reviewed changes
Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to go out on a limb and say the template you were pasting was in the version category :)

services/puppetforge/puppetforge-modules.service.js Outdated Show resolved Hide resolved
services/puppetforge/puppetforge-users.service.js Outdated Show resolved Hide resolved
services/amo/amo.service.js Outdated Show resolved Hide resolved
services/cran/cran.service.js Outdated Show resolved Hide resolved
services/redmine/redmine.service.js Outdated Show resolved Hide resolved
services/vaadin-directory/vaadin-directory.service.js Outdated Show resolved Hide resolved
services/vaadin-directory/vaadin-directory.service.js Outdated Show resolved Hide resolved
services/chrome-web-store/chrome-web-store.service.js Outdated Show resolved Hide resolved
@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-2349 November 19, 2018 02:50 Inactive
chris48s
chris48s approved these changes Nov 19, 2018
View reviewed changes
Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorted. I think this is good to go

@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-2349 November 19, 2018 19:28 Inactive
@paulmelnikow paulmelnikow merged commit ccfac2e into master Nov 19, 2018
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@paulmelnikow paulmelnikow deleted the all-badge-examples-almost-done branch November 19, 2018 20:25
@snyk-bot snyk-bot mentioned this pull request Apr 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris48s chris48s chris48s approved these changes

Assignees
No one assigned
Labels
blocker PRs and epics which block other work service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paulmelnikow @shields-ci @chris48s