Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Jenkins Cobertura Coverage Badge, run [Jenkins-Coverage] #2468

Merged
merged 3 commits into from
Dec 6, 2018
Merged

Fixes Jenkins Cobertura Coverage Badge, run [Jenkins-Coverage] #2468

merged 3 commits into from
Dec 6, 2018

Conversation

calebcartwright
Copy link
Member

Fixes #2346 - which describes the Jenkins cobertura test failures and discussed resolution approach.

I also added a live test for hitting a real cobertura API endpoint

@shields-ci
Copy link

Messages
📖 ✨ Thanks for your contribution to Shields, @calebcartwright!

Generated by 🚫 dangerJS

PyvesB
PyvesB approved these changes Dec 6, 2018
View reviewed changes
Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this, the changes look good to me! 👍

@PyvesB PyvesB merged commit a5bbe9a into badges:master Dec 6, 2018
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@paulmelnikow paulmelnikow added keep-service-tests-green Related to fixing failing tests of the services bug Bugs in badges and the frontend service-badge Accepted and actionable changes, features, and bugs labels Dec 6, 2018
@calebcartwright calebcartwright mentioned this pull request Dec 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PyvesB PyvesB PyvesB approved these changes

Assignees
No one assigned
Labels
bug Bugs in badges and the frontend keep-service-tests-green Related to fixing failing tests of the services service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@calebcartwright @shields-ci @PyvesB @paulmelnikow