Rewrite [DynamicXml] and [DynamicYaml] badges #2487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulmelnikow
added
the
service-badge
|
chris48s
approved these changes
Dec 12, 2018
| } | ||
| } | ||
|
|
||
| parseYml(buffer) { |
There was a problem hiding this comment.
I think it would be useful to extract this as a generic helper function so we can use it in the F-Droid service (and in a BaseYamlService in future)
Its a bit scope creep-ey though, so we could merge this PR and raise it as an issue for future so that we don't have to fiddle with the F-Droid badge in this PR, if you want.
There was a problem hiding this comment.
Makes sense. That came up in #2399 (comment), as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
server.js: remove a couple import renames.Blocking next steps in
server.js.