Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate service data + support labelColor for the endpoint badge #2740

Merged
merged 10 commits into from
Jan 13, 2019
Merged

Validate service data + support labelColor for the endpoint badge #2740

merged 10 commits into from
Jan 13, 2019

Conversation

paulmelnikow
Copy link
Member

Ref #2473

@paulmelnikow paulmelnikow added core Server, BaseService, GitHub auth blocker PRs and epics which block other work labels Jan 11, 2019
@shields-ci
Copy link

shields-ci commented Jan 11, 2019 •
edited
Loading

Warnings
⚠️

Found 'assert' statement added in services/base.js.
Please ensure tests are written using Chai expect syntax
Messages
📖 ✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS against 66e9176

@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-2740 January 11, 2019 21:43 Inactive
@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-2740 January 11, 2019 22:12 Inactive
@paulmelnikow paulmelnikow mentioned this pull request Jan 11, 2019
Merged
10 tasks
@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-2740 January 12, 2019 04:16 Inactive
@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-2740 January 12, 2019 05:06 Inactive
@paulmelnikow
Copy link
Member Author

Failures seem unrelated. GemRank fixed in #2743.

@paulmelnikow paulmelnikow changed the title Validate service data + support labelColor for the endpoint badge [*] Validate service data + support labelColor for the endpoint badge Jan 12, 2019
@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-2740 January 12, 2019 22:41 Inactive
@chris48s chris48s mentioned this pull request Jan 13, 2019
Merged
@paulmelnikow paulmelnikow merged commit 5c25dce into master Jan 13, 2019
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@paulmelnikow paulmelnikow deleted the validate-service-data branch January 13, 2019 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris48s chris48s chris48s approved these changes

Assignees
No one assigned
Labels
blocker PRs and epics which block other work core Server, BaseService, GitHub auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paulmelnikow @shields-ci @chris48s