Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added [Cirrus] CI badge support #3502

Merged
merged 66 commits into from
Jun 15, 2019
Merged

Added [Cirrus] CI badge support #3502

merged 66 commits into from
Jun 15, 2019

Conversation

RDIL
Copy link
Contributor

@RDIL RDIL commented May 29, 2019 •
edited by calebcartwright
Loading

@shields-ci
Copy link

shields-ci commented May 29, 2019 •
edited
Loading

Messages
📖 ✨ Thanks for your contribution to Shields, @RDIL!

Generated by 🚫 dangerJS against c055f08

@paulmelnikow
Copy link
Member

This pull request introduces 1 alert when merging 82db96f into 65dba94 - view on LGTM.com

new alerts:

  • 1 for Syntax error

Comment posted by LGTM.com

@calebcartwright calebcartwright added the service-badge Accepted and actionable changes, features, and bugs label May 29, 2019
@RDIL
Copy link
Contributor Author

RDIL commented May 29, 2019

Okay, going to need a little help now here @fkorotkov 😅

@paulmelnikow
Copy link
Member

This pull request introduces 1 alert when merging 2d4128e into f50fcac - view on LGTM.com

new alerts:

  • 1 for Syntax error

Comment posted by LGTM.com

@paulmelnikow
Copy link
Member

This pull request introduces 1 alert when merging cc44096 into f50fcac - view on LGTM.com

new alerts:

  • 1 for Syntax error

Comment posted by LGTM.com

@fkorotkov fkorotkov mentioned this pull request Jun 7, 2019
Closed
@paulmelnikow
Copy link
Member

This pull request introduces 1 alert when merging f568eba into e102946 - view on LGTM.com

new alerts:

  • 1 for Syntax error

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com

@calebcartwright calebcartwright changed the title Added Cirrus CI badge support Added [Cirrus] CI badge support Jun 8, 2019
@calebcartwright
Copy link
Member

calebcartwright commented Jun 9, 2019 •
edited
Loading

I'm not familiar with Cirrus CI, so I have a couple questions I'm hoping you can help me with.

Based off some of the content you've added, I take it in addition to adding support for the default build status badge:

  1. Cirrus also provides a status badge for a specific branch (which is obviously common with other CI services and our badges), and you want users to be able to create a build status badge for a specific branch?
  2. Cirrus also provides a status badge for some subset/part/step of a build (which I'm guessing is what you're trying to support with the task and/or script query params?

Is that correct?

@RDIL
Copy link
Contributor Author

RDIL commented Jun 9, 2019

  1. Yes
  2. Yes again

Full documentation is at https://cirrus-ci.org

@RDIL @calebcartwright
Update services/cirrus/cirrus.service.js
3533022 
Co-Authored-By: Caleb Cartwright <calebcartwright@users.noreply.github.com>
@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-3502 June 11, 2019 23:34 Inactive
RDIL and others added 3 commits June 11, 2019 19:34
@RDIL @calebcartwright
Update services/cirrus/cirrus.service.js
516f528 
Co-Authored-By: Caleb Cartwright <calebcartwright@users.noreply.github.com>
@RDIL @calebcartwright
Update services/cirrus/cirrus.service.js
40c7660 
Co-Authored-By: Caleb Cartwright <calebcartwright@users.noreply.github.com>
@RDIL @calebcartwright
Update services/cirrus/cirrus.service.js
17f255c 
Co-Authored-By: Caleb Cartwright <calebcartwright@users.noreply.github.com>
@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-3502 June 11, 2019 23:34 Inactive
@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-3502 June 11, 2019 23:34 Inactive
@RDIL @calebcartwright
Update services/cirrus/cirrus.service.js
f3b606e 
Co-Authored-By: Caleb Cartwright <calebcartwright@users.noreply.github.com>
@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-3502 June 11, 2019 23:34 Inactive
@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-3502 June 11, 2019 23:34 Inactive
@RDIL @calebcartwright
Update services/cirrus/cirrus.service.js
5da8696 
Co-Authored-By: Caleb Cartwright <calebcartwright@users.noreply.github.com>
@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-3502 June 11, 2019 23:35 Inactive
@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-3502 June 11, 2019 23:35 Inactive
@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-3502 June 13, 2019 14:26 Inactive
@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-3502 June 15, 2019 18:52 Inactive
@RDIL @fkorotkov
Update services/cirrus/cirrus.service.js
c055f08 
Co-Authored-By: Fedor Korotkov <fedor.korotkov@gmail.com>
@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-3502 June 15, 2019 19:19 Inactive
@calebcartwright
Copy link
Member

Thanks so much for this!

@calebcartwright calebcartwright merged commit 0808a70 into badges:master Jun 15, 2019
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkorotkov fkorotkov fkorotkov left review comments

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proper badge support with shields.io Badge request: Cirrus CI
5 participants
@RDIL @shields-ci @paulmelnikow @calebcartwright @fkorotkov