Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Gitpod automated setup #3880

Merged
merged 4 commits into from
Aug 29, 2019
Merged

Improve Gitpod automated setup #3880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1573436
Gitpod is no longer in Beta
jankeromnes Aug 18, 2019
275fa49
Automatically open the web preview on start-up in Gitpod
jankeromnes Aug 18, 2019
1212be6
Accelerate Gitpod start-up with continuously prebuilt workspaces
jankeromnes Aug 18, 2019
2d4a2e6
Install Prettier VS Code extension in Gitpod
jankeromnes Aug 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions .gitpod.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,27 @@
ports:
- port: 8080
onOpen: open-preview
tasks:
- init: npm ci && npm run build
command: node server 8080 0.0.0.0
github:
prebuilds:
# enable for the master/default branch (defaults to true)
master: true
# enable for all branches in this repo (defaults to false)
branches: true
# enable for pull requests coming from this repo (defaults to true)
pullRequests: true
# enable for pull requests coming from forks (defaults to false)
pullRequestsFromForks: true
# add a check to pull requests (defaults to true)
addCheck: true
# add a "Review in Gitpod" button as a comment to pull requests (defaults to false)
addComment: true
# add a "Review in Gitpod" button to the pull request's description (defaults to false)
addBadge: false
# add a label once the prebuild is ready to pull requests (defaults to false)
addLabel: false
vscode:
extensions:
- esbenp.prettier-vscode@1.7.0:EbyqFvwe32qQBptkOgfQpQ==
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ It also works with full URLs like
Use `npm run debug:server` to start server in debug mode.
[This recipe][nodemon debug] shows how to debug Node.js application in [VS Code][].

Shields has experimental support for [Gitpod Beta][gitpod], a pre-configured development
Shields has experimental support for [Gitpod][gitpod], a pre-configured development
environment that runs in your browser. To use Gitpod, click the button below and
sign in with GitHub. Gitpod also offers a browser add-on, though it is not required.
Please report any Gitpod bugs, questions, or suggestions in issue
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this line was already in here, but wouldn't it be better to have folks direct their Gitpod related bugs/questions/etc. to Gitpod?

I know I wouldn't be the best person to help folks out with Gitpod related questions/issues/etc. and I suspect most of the other Shields maintainers don't have Gitpod expertise either.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's kind of the goal of that issue, is to funnel people to one place to get help.

Though I think it's true that none of the Shields maintainers are very familiar with Gitpod, and while as a collective we're well-equipped to support Shields in various environments, we're not well-equipped to support Gitpod.

Jan, I wonder if you could clarify what level of support you and/or Gitpod are available to respond to problems people might run into.

We haven't exactly been crushing under a load of support requests; in fact I haven't seen any. Since you say people are using it, they are either managing okay, or not raising issues in any of the Shields forums. Though I do get where the core team is coming from, in setting expectations that this is something where we will need your help to provide support.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the additional feedback!

wouldn't it be better to have folks direct their Gitpod related bugs/questions/etc. to Gitpod?

That's an excellent point. And @paulmelnikow is right: that's indeed the goal behind issue #2772. I'm subscribed to it, and will see / be able to reply to any comment posted there.

Jan, I wonder if you could clarify what level of support you and/or Gitpod are available to respond to problems people might run into.

Sure! So for Gitpod-related problems or questions in Shields, please feel free to redirect anyone to #2772, or to @mention me directly in any discussion where you feel my input could be helpful. I'm happy to spend both working hours and personal time on helping out Shields developers with Gitpod. 馃檪

Since you say people are using it, they are either managing okay, or not raising issues in any of the Shields forums.

I do hope it's the former! 馃 We've put significant effort into the Shields/Gitpod dev experience. But if you notice anyone struggling with / being annoyed by something that looks somewhat Gitpod-related, please ping me if possible. 馃檹

Copy link
Member

@calebcartwright calebcartwright Aug 26, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That helps a lot, thanks for additional the context!

Expand Down