added support for shippable #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You do need a couple of installed libraries to run shields: phantomjs and cairo (see here). It would be preferable to avoid SVG scraping. Do you know if there are plans to support this in Shippable's standard API? Your PR as it stands triggers an Internal Server Error in shippable's server. |
| cache(function(data, match, sendBadge, request) { | ||
| var project = match[2]; // eg, 54d119db5ab6cc13528ab183 | ||
| var branch = match[3]; | ||
| var format = match[4]; |
|
Thanks for contributing anywho! |
|
@espadrine thing is: for some reason I can't install cairo here.. got different errors every time... Don't know about the shippable api.. Thanks! |
|
@espadrine @caarlos0 it seems like this service no longer works, it requires adding a whitespace replace to Sending in a PR for the same |
|
@mahirk yeah, maybe they changed the API... |
| @@ -312,6 +312,41 @@ cache(function(data, match, sendBadge, request) { | |||
| }); | |||
| })); | |||
|
|
|||
| // Shippable integration | |||
| camp.route(/^\/shippable?\/([^\/]+)(?:\/(.+))?\.(svg|png|gif|jpg|json)$/, | |||
There was a problem hiding this comment.
The first ? seems unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't able to test it in my machine though (problems with node-gyp)...
Anyways, I think it should work that way..