Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check request origin before sending credentials, affects [AzureDevops Bintray Bitbucket Drone GitHub Jenkins Jira Nexus NPM Sonar Symfony TeamCity Wheelmap] #4729

Merged
merged 1 commit into from
Mar 4, 2020

Conversation

PyvesB
Copy link
Member

@PyvesB PyvesB commented Mar 4, 2020

This pull request adds a new authorizedOrigins configuration key for a number of services which have the ability to send credentials to user-defined endpoints. More information about the impact of this will be published shortly.

This pull request was a joint effort from @calebcartwright, @chris48s, @paulmelnikow and myself.

Co-authored-by: Caleb Cartwright <calebcartwright@users.noreply.github.com>
Co-authored-by: Paul Melnikow <github@paulmelnikow.com>
Co-authored-by: chris48s <chris48s@users.noreply.github.com>
@PyvesB PyvesB added service-badge Accepted and actionable changes, features, and bugs self-hosting Discussion, problems, features, and documentation related to self-hosting Shields core Server, BaseService, GitHub auth security Refer to our SECURITY.md policy before opening pull requests that address a security vulnerability labels Mar 4, 2020
@shields-ci
Copy link

Warnings
⚠️ This PR modified service code for azure-devops but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for bintray but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for bitbucket but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for drone but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for jira but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for nexus but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for wheelmap but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @PyvesB!
📖

Thanks for contributing to our documentation. We ❤️ our documentarians!

Generated by 🚫 dangerJS against d4bd3ae

@chris48s chris48s merged commit d883172 into badges:master Mar 4, 2020
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@chris48s
Copy link
Member

chris48s commented Mar 4, 2020

link #4730

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Server, BaseService, GitHub auth security Refer to our SECURITY.md policy before opening pull requests that address a security vulnerability self-hosting Discussion, problems, features, and documentation related to self-hosting Shields service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants