Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to got 11; test on [github] #5008

Merged
merged 3 commits into from
May 2, 2020
Merged

upgrade to got 11; test on [github] #5008

merged 3 commits into from
May 2, 2020

Conversation

chris48s
Copy link
Member

@chris48s chris48s commented May 1, 2020

..just because it was mostly already done

@chris48s chris48s added the dependencies Related to dependency updates label May 1, 2020
@shields-ci
Copy link

shields-ci commented May 1, 2020

Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against fed0db7

@calebcartwright
Copy link
Member

Anyone else seeing this on some of these PRs where the update button is just missing?

image

@chris48s
Copy link
Member Author

chris48s commented May 2, 2020

nope

Screenshot at 2020-05-02 17-24-48

@calebcartwright
Copy link
Member

I'm only seeing it on a couple of PRs coming from your fork, but it's there on others 🤔

odd 🤷‍♂️

@chris48s chris48s merged commit 4d275e0 into badges:master May 2, 2020
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@paulmelnikow
Copy link
Member

Yea, I'm seeing it too on PR's on Chris's fork. Maybe the checkbox "let maintainers edit" is unchecked?

@chris48s
Copy link
Member Author

chris48s commented May 2, 2020

I've not been knowingly un-ticking it..
I just submitted #5037 and made sure "allow edits by maintainers" is definitely ticked when I submitted it. Have a look at that one..

@calebcartwright
Copy link
Member

Working on #5037 👍

image

@paulmelnikow paulmelnikow mentioned this pull request May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Related to dependency updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants