Add ImageLayers.io Docker Hub layer information service

[andyshinn]

This adds a ImageLayers.io badge (which resembles the same data in their own badge). I wanted to use their badge. But it didn't conform to the look of all the other ones I was already using from shields.io.

This also adds a small filesize package. It was a quick way to do humanized file sizes. If this undesirable, I can try and rework it without.

[moul]

👍

[espadrine]

I believe, from request's documentation, that the json entry is meant to either be falsy or true.

[andyshinn]

Yep, my bad. I see now that this should be in the body per docs:

body - entity body for PATCH, POST and PUT requests. Must be a Buffer or String, unless json is true. If json is true, then body must be a JSON-serializable object.

[espadrine]

Thanks for your contribution!

I cannot get it to work, however. I am not sure what curl to do to test what ought to work, either. Could you help out?

[andyshinn]

Sure, I was using something like:

curl -sSL -H 'Content-Type: application/json' -X POST -d '{"repos": [{"name": "library/ubuntu", "tag": "latest"}]}' "https://imagelayers.io:8888/registry/analyze" | jq '.[].repo'

You can remove the `| jq '.[].repo' part if you don't have jq installed.

[espadrine]

Thanks!

I have two queries.

1. Usually, we strive to ensure that the left part of the badge reflects what the right part means (eg, coverage, build, downloads, …) What would the most appropriate non-brand description be? "image size" perhaps?
2. To prepare for the possibility that a particular brand starts producing multiple services, we rely on a prefix. For instance, /imagelayers/image-size/_/ubunutu/latest.svg (adding image-size). Could you add that in (or whatever is more appropriate than image-size)?

[andyshinn]

I guess we could have image size and layers as two separate badges. In this case, should the prefix just be image-size and layers respectively?

[espadrine]

That sounds good!

[andyshinn]

Updated to separate into two types image-size and layers.

[espadrine]

Could you detail the purpose of this line?

[espadrine]

Thanks! Apart from those tangential issues, it seems all good.

[andyshinn]

Sorry, those shouldn't have been in the commit. Side note... the PhantomJS npm install doesn't work for me on the default mirror. Could be local issue though.

[espadrine]

Ah, damned. It it a pinned version on package.json; I'm not sure what is wrong there. I should try to update the project to a newer version of node. Maybe all our worries will evaporate.

[espadrine]

Thanks a lot!

I just noticed that the badge says image-size (with a dash). If you want, you can remove the dash as a follow-up PR.

[andyshinn]

My JavaScript wasn't up to snuff to elegantly solve that and it didn't bother me enough :)