Fix broken travis branches #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, Looks like when you request a build status for a branch it ignores the branch! Seems a typo in the code. Jason
|
Good lord, you're right! Thank you! |
|
I think the original issue I was raising here ( #528 ) is addressed by this change. However, I think discussion in that issue turned to a potentially different issue so I will leave it open for now. |
|
Is it possible the HHVM branch badge is suffering from a similar problem? |
|
Also, TeamCity CodeBetter Coverage badge is complaining it is malformed. Wondering if a similar fix would help it. |
|
Usually, those caused by a change in the format of the data. Adding a breakpoint in server.js reveals what needs fixing. But it is a game of whack-a-mole, so patches are very welcome! |
This was referenced Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Looks like when you request a build status for a branch it ignores the branch!
Seems a typo in the code.
Jason