implement path collapsing #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a Travis badge to our README, using origin.shields.io.
We build our own virtualenv and we want Travis CI to use that instead of its own.
This includes more tests. Next step is to wire this up in an Aspen hook to run at request time.
This applies the util from the last commit to the Aspen request processing cycle.
This gives us an environment for testing
|
Okay @olivierlacan, with this PR we:
So ... https://shields.io/foo/bar%2Fbaz.png ... will redirect to ... https://shields.io/foo/bar/baz.png ... and that will be served as if it had been a request for a Does that sound like the behavior we're after? |
I wrote this comment before deciding to just write another test for what the comment was presuming.
|
@whit537 That's quite jolly good my friend. 👍 |
|
Cool, once I convince Travis that these tests pass I'll merge and deploy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-on from #57.