Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build(deps): bump simple-icons from 5.2.0 to 5.3.0 #6662

Merged
merged 3 commits into from
Jun 27, 2021

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Jun 25, 2021

Bumps simple-icons from 5.2.0 to 5.3.0.

Release notes

Sourced from simple-icons's releases.

Release 12 new icons and 4 updated icons (v5.3.0)

New Icons

Updated Icons


⚠️ The old Foursquare SVG can now be found as Foursquare City Guide, see #5989 for more info.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added the dependencies Related to dependency updates label Jun 25, 2021
@shields-cd shields-cd temporarily deployed to shields-staging-pr-6662 June 25, 2021 12:20 Inactive
@calebcartwright
Copy link
Member

calebcartwright commented Jun 26, 2021

There's arguably a case to be made that this constitutes a breaking change for our users in the sense that when we deploy this update existing users of the foursquare logo slug will see a different icon, and would need to update their logo slug to foursquare-city-guide to go back to what they have currently (upstream change made in simple-icons/simple-icons#5989)

https://img.shields.io/badge/foo-bar-blue?logo=foursquare

https://shields-staging-pr-6662.herokuapp.com/badge/foo-bar-blue?logo=foursquare

https://shields-staging-pr-6662.herokuapp.com/badge/foo-bar-blue?logo=foursquare-city-guide

I don't see any way around this outside waiting til SI v6 before pulling in any SI updates and doing our typical announcement about a major version upgrade, which doesn't seem remotely feasible nor does it really change the end result. I'd propose we carry on with this and maybe just add a discussion item or pinned issue detailing this with the reference to the city-guide slug for those that want to go back to the current icon

Bumps [simple-icons](https://github.com/simple-icons/simple-icons) from 5.2.0 to 5.3.0.
- [Release notes](https://github.com/simple-icons/simple-icons/releases)
- [Commits](simple-icons/simple-icons@5.2.0...5.3.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/simple-icons-5.3.0 branch from 4e89555 to 0961d25 Compare June 26, 2021 01:38
@shields-cd shields-cd temporarily deployed to shields-staging-pr-6662 June 26, 2021 01:38 Inactive
@chris48s
Copy link
Member

I'd propose we carry on with this and maybe just add a discussion item or pinned issue detailing this

agreed 👍

@LitoMore
Copy link
Contributor

Now simple-icons@5.4.0 released.

Shall we upgrade simple-icons to 5.4.0 in this PR?

@shields-cd shields-cd temporarily deployed to shields-staging-pr-6662 June 27, 2021 18:13 Inactive
@calebcartwright
Copy link
Member

@LitoMore - I appreciate folks' interest in getting icon updates, but we have a very explicit process that we follow for pulling in Simple Icon updates (refs #5369) and we don't change that process just because we need extra discussion/work to pull in one update as was the case here.

@calebcartwright calebcartwright merged commit af9b309 into master Jun 27, 2021
@calebcartwright calebcartwright deleted the dependabot/npm_and_yarn/simple-icons-5.3.0 branch June 27, 2021 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Related to dependency updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants