Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: for crates.io versions, use max_stable_version if it exists [CRATES] #8667

Conversation

zeeshanlakhani
Copy link
Contributor

Proposal to fix/handle #8666.

@zeeshanlakhani zeeshanlakhani changed the title [CRATES] fix: for crates.io versions, use max_stable_version if it exists fix: for crates.io versions, use max_stable_version if it exists [CRATES] Nov 30, 2022
@chris48s
Copy link
Member

chris48s commented Dec 4, 2022

Thanks for submitting this and the extra info in #8666 . There are couple of problems here:

  1. CircleCI isn't running the service tests from your fork. This is a known issue affecting some contributors. We're working on migrating away from it (hence the current random mashup of GH actions and Circle CI)
  2. Looking at this code has made me realise there is another issue here.

I've moved this change to PR #8687 but I've left you as the commit (co-)author

@chris48s chris48s closed this Dec 4, 2022
@zeeshanlakhani zeeshanlakhani deleted the zl/max_stable_version_proposal branch December 4, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants