update [githubpipenv] tests/examples #8797
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly a standard "update the test/example" PR, but there was a confusing wrinkle to this one.
The service tests were failing, but the badge was actually working in production.
https://img.shields.io/github/pipenv/locked/dependency-version/metabolize/rq-dashboard-on-heroku/rq-dashboard/master totally works.
The reason is this code here:
shields/services/github/github-common-fetch.js
Lines 58 to 75 in 0c73b35
In production,
staticAuthConfigured
is false because we use the token pool. https://raw.githubusercontent.com/metabolize/rq-dashboard-on-heroku/master/Pipfile.lock still works if you rename your master branch to main, even though there is no master branch any more. The/contents
API doesn't do that, hence the difference in behaviour.