Fix: [GithubCommitActivity] invalid branch error handling #9258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When GraphQL response with a bad repo it returns an error indicating the bad repo. When GraphQL has the currect repo with a bad branch it will null inside the repo object without an error object. The privouse commits seems to try and use that but due not allowing null in schema it did not work and an error due to bad schema would show insted. This commit fixes this issue
chris48s
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current code to handle invalid branch in Github Commit Activity (branch) never runs.
When GraphQL response with a bad repo it returns an error indicating the bad repo.
When GraphQL has the correct repo with a bad branch it will return null inside the repo object without an error object.
The existing code seems to try and use that but due to the current Joi schema not allowing null it did not work and an error due to bad schema would show instead.
This PR fixes this issue and adds a test for this case
Photo from production showing invalid response data due to response differ from schema:
Photo of PR changes on my local debug instance, handling invalid branch: