Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate [snyk] badges #9349

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Conversation

chris48s
Copy link
Member

@chris48s chris48s commented Jul 3, 2023

Closes #9325

As far as I am aware, there is no way we can re-implement the old functionality.
Nobody has suggested anything better.
I suggest we deprecate them.

@chris48s chris48s added the service-badge Accepted and actionable changes, features, and bugs label Jul 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against c4675b0

Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the right path forward to me too. Can always reintroduce them should something change upstream with the API to make it possible to provide badges again

@repo-ranger repo-ranger bot merged commit 7bad3f5 into badges:master Jul 3, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snyk vulnerabilities shield shows 'Invalid response data'
2 participants