Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with custom logo generation in badge-maker (#9644) #9645

Closed
wants to merge 8 commits into from
Closed

Fix issue with custom logo generation in badge-maker (#9644) #9645

wants to merge 8 commits into from

Commits on Jun 18, 2024

  1. fix issue with custom logo generation (badges#9644) 

    * allow `logo`, `logoPosition`, `logoWidth`, and `links` as expected keys

* add validation for `logo`, `logoPosition`, `logoWidth`, and `links` keys

* add validation tests
    @zavoloklom
    zavoloklom committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    064d188 View commit details
    Browse the repository at this point in the history

  2. chore: rename logo to logoBase64

    @zavoloklom
    zavoloklom committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    a5111e6 View commit details
    Browse the repository at this point in the history

  3. chore: remove logoPosition, mark logoWidth as deprecated

    @zavoloklom
    zavoloklom committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    ea0d27f View commit details
    Browse the repository at this point in the history

  4. chore: add links array lenght validation

    @zavoloklom
    zavoloklom committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    7ed1a40 View commit details
    Browse the repository at this point in the history

  5. docs: add properties description and examples

    @zavoloklom
    zavoloklom committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    72281eb View commit details
    Browse the repository at this point in the history

  6. chore: remove logoWidth from exposed params

    @zavoloklom
    zavoloklom committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    aca270d View commit details
    Browse the repository at this point in the history

  7. chore: remove logoWidth from makeBadge function

    @zavoloklom
    zavoloklom committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    c583fc7 View commit details
    Browse the repository at this point in the history

  8. chore: change magic number to constant for default logo height

    @zavoloklom
    zavoloklom committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    6601fc0 View commit details
    Browse the repository at this point in the history