migrate examples to openApi part 25; affects [ctan dub hexpm jira pulsar scoop] #9749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris48s
added
service-badge
|
chris48s
commented
Nov 19, 2023
| @@ -96,52 +108,58 @@ class HexPmVersion extends BaseHexPmService { | |||
| } | |||
| } | |||
|
|
|||
| function DownloadsForInterval(downloadInterval) { | |||
There was a problem hiding this comment.
There is a bit of refactoring going on here.
Previously, this service used the same pattern we see in #9732 (comment)
Previously we defined a function that returns a class, and then called that function with 'day', 'week' and 'all' to generate 3 classes. One for each interval.
I don't think this really buys us much here. I converted this to a single class with an :interval(dd|dw|dt) param. This allows us to have a single example page and show interval as a drop-down menu, which is much more in line with how we do all our other downloads badges.
chris48s
changed the title
PyvesB
approved these changes
Dec 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #9285
I wonder what number the last of these PRs will be?