Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate examples to openApi part 37; affects [bitbucket bitrise chromewebstore circleci] #9881

Merged
merged 5 commits into from
Feb 14, 2024

Conversation

PyvesB
Copy link
Member

@PyvesB PyvesB commented Jan 6, 2024

Refs #9285.

Leaving as draft for now, gonna see if I can find some good updated Bitbucket examples. All tests and examples fixed.

@PyvesB PyvesB added service-badge Accepted and actionable changes, features, and bugs documentation Developer and end-user documentation labels Jan 6, 2024
Copy link
Contributor

github-actions bot commented Jan 6, 2024

Warnings
⚠️ This PR modified service code for chrome-web-store but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @PyvesB!

Generated by 🚫 dangerJS against 9bf7f2b

@PyvesB
Copy link
Member Author

PyvesB commented Jan 7, 2024

I've set up a sample repository at https://bitbucket.org/shields-io/test-repo to get everything working for examples and Bitbucket tests.

Bitrise and CircleCI are also failing, will look into them later.

@PyvesB PyvesB marked this pull request as ready for review January 7, 2024 21:26
Copy link
Contributor

github-actions bot commented Jan 8, 2024

🚀 Updated review app: https://pr-9881-badges-shields.fly.dev

@PyvesB
Copy link
Member Author

PyvesB commented Feb 12, 2024

@chris48s there you go, ready for review with all tests fixed!

Copy link
Contributor

🚀 Updated review app: https://pr-9881-badges-shields.fly.dev

}),
queryParam({
name: 'token',
example: 'abc123def456',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

were you planning to update the examples too, or only the tests?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the tests, that's what I asked for in the linked issue.

@chris48s chris48s added this pull request to the merge queue Feb 14, 2024
Merged via the queue into badges:master with commit cb2ebe2 Feb 14, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Developer and end-user documentation service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants