update deps to support OpenSSL v3+ #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds reasonable. Surprisingly though, updating these does appear to introduce some lint errors though. |
I think it's unrelated and suspect it's just the first build we've had in a while that compiled successfully and allowed the lint stage to run with the latest Rust (our CI is currently live streaming the latest Rust release, which is on a ~6 week release cycle) which includes some enhancements allowing for better lint detection |
calebcartwright
force-pushed
the
openssl3
branch
from
cb90216
to
b76b05d
Compare
calebcartwright
force-pushed
the
openssl3
branch
from
b76b05d
to
72d9f1b
Compare
|
ah that makes sense - I couldn't see anything in the updated dependencies that looked like it would affect linting |
chris48s
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated to an OS version which utilizes OpenSSL v3, and we'll run into the same whenever we get back around to the updates needed for #78.
In the interim, I'd like to go ahead and update some of our transitive dependencies to newer versions which bring support for OpenSSL v3. Note that I've tested this locally for emoji compatibility out of an abundance of caution, and as expected this does not introduce any emoji related issues.