Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text bubble fixes #127

Merged
merged 3 commits into from
May 12, 2016

Conversation

diegosanchezr
Copy link
Contributor

@diegosanchezr diegosanchezr commented May 9, 2016

Fixes #126 and #129

@codecov-io
Copy link

codecov-io commented May 9, 2016

Current coverage is 65.13%

Merging #127 into dev will increase coverage by +0.28%

  1. File ...hotoBubbleView.swift (not in diff) was modified. more
@@                dev       #127   diff @@
==========================================
  Files            60         60          
  Lines          3143       3169    +26   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           2038       2064    +26   
  Misses         1105       1105          
  Partials          0          0          

Powered by Codecov. Last updated by 92d6c0c...54e3435

@diegosanchezr diegosanchezr force-pushed the arabic-diacritic-marks-clipped branch from 54e3435 to 90b64d9 Compare May 10, 2016 17:57
This changes how text insetting is performed. By using non-zero textInsets, UITextView size is now bigger and diacritic marks can be seen.
…strings - which was leading to incorrect size of text bubbles -
@diegosanchezr diegosanchezr force-pushed the arabic-diacritic-marks-clipped branch from 90b64d9 to 5a15c87 Compare May 11, 2016 16:42
@diegosanchezr diegosanchezr merged commit 3b62da4 into badoo:dev May 12, 2016
@diegosanchezr diegosanchezr deleted the arabic-diacritic-marks-clipped branch May 12, 2016 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants