Fixing the linker issue when using Carthage to build Chatto 3.0 library with Xcode 8 #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Undefined symbols for architecture arm64:
"direct field offset for
ChattoAdditions.BaseMessageCollectionViewCell.(failedButton.storage in
_199F15D9372F4972CA55EC8780E2E384) : __ObjC.UIButton?", referenced from:
ChattoAdditions.BaseMessageCollectionViewCell.failedButton.setter
: __ObjC.UIButton in PTextMessageCollectionViewCell.o
ChattoAdditions.BaseMessageCollectionViewCell.(failedButton.materializeF
orSet : __ObjC.UIButton).(closure #1) in
PTextMessageCollectionViewCell.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see
invocation)
Current coverage is 72.40% (diff: 100%)@@ master #232 diff @@
==========================================
Files 86 86
Lines 4679 4679
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 3388 3388
Misses 1291 1291
Partials 0 0
|
|
Thanks @zwang!! Consider opening a bug about this in https://bugs.swift.org |
|
OK, I will do some research and figure out an minimal app to re-produce this later. Kind of busy in these two weeks. Feel free to do by yourself too if you are curious. Thanks for the quick merge. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@diegosanchezr firstly thanks a lot for the quick update to swift3. I updated to v3.0. Seems works well so far. Great work from you as always 👍
Just found this issue preventing me to build successfully if I have a sub classes of BaseMessageCollectionView.
A similar discussing is found here and hint me the fix: xmartlabs/XLPagerTabStrip#227
I don't know the real reason about the fix. Guess might be some issue with Xcode. But the code change below did fix the issue luckily. Tested at my local.
Error messages shown as below for this error:
Undefined symbols for architecture arm64:
Thanks again for the great work! 👍 😄