Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timestamp separator in message view using extra DecoratedChatItem #58

Merged
merged 2 commits into from
Mar 13, 2016
Merged

Conversation

zwang
Copy link
Contributor

@zwang zwang commented Mar 13, 2016

Just show an example of how to accomplish user case mentioned in #9 according to @diegosanchezr 's suggestion

See screenshot below. The timestamp separator is at the top
simulator screen shot mar 11 2016 11 48 55 pm

@codecov-io
Copy link

Current coverage is 62.40%

Merging #58 into dev will not affect coverage as of 5cb720c

@@             dev    #58   diff @@
===================================
  Files         57     57       
  Stmts       2857   2857       
  Branches       0      0       
  Methods        0      0       
===================================
  Hit         1783   1783       
  Partial        0      0       
  Missed      1074   1074       

Review entire Coverage Diff as of 5cb720c

Powered by Codecov. Updated on successful CI builds.

@zwang
Copy link
Contributor Author

zwang commented Mar 13, 2016

Also resolved potential self.dynamicType issue found earlier.

diegosanchezr added a commit that referenced this pull request Mar 13, 2016
Time separators in ChattoApp. Also removes dynamicType when fetching resources from the framework.
@diegosanchezr diegosanchezr merged commit 78aa23d into badoo:dev Mar 13, 2016
@diegosanchezr
Copy link
Contributor

Thank you very much @zwang!

@zwang
Copy link
Contributor Author

zwang commented Mar 13, 2016

Thank you! @diegosanchezr 👍

I think we can also close #9 now. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants