Improvements for custom styling #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is
|
- Allows reusing default styles by injecting parameters - Insets and fonts for input component
diegosanchezr
changed the title
…arance don't work for any app (unlocalized texts) so it's better to remove the default value and make existing apps get a compiler error.
| @@ -73,9 +74,15 @@ class AccessoryViewRevealer: NSObject, UIGestureRecognizerDelegate { | |||
| } | |||
|
|
|||
| private func revealAccessoryView(atOffset offset: CGFloat) { | |||
| // Find max offset (cells can have slighlty different timestamp size ( 3.00 am vs 11.37 pm ) | |||
| let cells: [AccessoryViewRevealable] = self.collectionView.visibleCells().filter({$0 is AccessoryViewRevealable}).map({$0 as! AccessoryViewRevealable}) | |||
There was a problem hiding this comment.
I think we ca write it like this .filter(...) as! [AccessoryViewRevealable]
There was a problem hiding this comment.
It doesn't compile unfortunately: 'AccessoryViewRevealable' is not a subtype of 'UICollectionViewCell'
Viacheslav-Radchenko
added a commit
that referenced
this pull request
Mar 22, 2016
Improvements for custom styling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows better reuse of default styles in cells
Allows better customization of input component