Remove debug and add comments

badsyntax · Dec 18, 2020 · 8fde7be · 8fde7be
1 parent af52162
commit 8fde7be
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -31,4 +31,5 @@ jobs:
       - name: Run tests
         run: sudo make test
         env:
-          HOSTNAME: "an-engine.com"
+          # "an-engine" is used to test the env var parsing logic (-e), see issue #13
+          HOSTNAME: "an-engine.discourse.dokku.me"
diff --git a/internal-functions b/internal-functions
@@ -191,16 +191,12 @@ fn-configure-app() {
   dokku_log_info1 "Generating docker config..."
 
   local RUN_ARGS MAC_ADDRESS SHM_SIZE ENV_VARS
-  RUN_ARGS=$(fn-get-run-args "$APP_NAME" 2>&1)
-
-  echo "# RUN_ARGS: $RUN_ARGS"
 
+  RUN_ARGS=$(fn-get-run-args "$APP_NAME" 2>&1)
   MAC_ADDRESS=$(echo "$RUN_ARGS" | sed -r 's/.*--mac-address(=| )([^ ]+).*/\2/')
   SHM_SIZE=$(echo "$RUN_ARGS" | sed -r 's/.*--shm-size(=| )([^ ]+).*/\2/')
   ENV_VARS=$(fn-get-env-vars-from-run-args "$RUN_ARGS")
 
-  echo "# ENV_VARS: $ENV_VARS"
-
   domains_set "$APP_NAME" "$HOSTNAME"
 
   ## TODO: call plugin functions instead of dokku