Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ps:set-restart-policy being deprecated on dokku 0.22.0 #11

Merged
merged 2 commits into from
Dec 10, 2020

Conversation

whollacsek
Copy link
Contributor

Fixing this issue: #10

@badsyntax
Copy link
Owner

Thanks for this. Can you update the dokku version in the workflow test.yml file to get the tests to pass?

@whollacsek
Copy link
Contributor Author

Done it should be good in few moments 👍

@badsyntax
Copy link
Owner

Test still failing due to removal of ps_stop (see dokku/dokku#4149)

I believe you can replace this line:

[[ -n $("$DOCKER_BIN" ps -q -f ancestor="dokku/$APP_NAME") ]] && ps_stop "$APP_NAME"

With

[[ -n $("$DOCKER_BIN" ps -q -f ancestor="dokku/$APP_NAME") ]] && dokku ps:stop "$APP_NAME"

Once that change is made i'll merge, and then i'll follow up with some additional changes for better support across different versions.

@badsyntax badsyntax merged commit 0c82e49 into badsyntax:master Dec 10, 2020
@badsyntax
Copy link
Owner

Thanks for the contribution. I have added a follow up PR with #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants