Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot get Demo to run #26

Closed
mccare opened this issue Jan 29, 2019 · 2 comments
Closed

Cannot get Demo to run #26

mccare opened this issue Jan 29, 2019 · 2 comments
Labels

Comments

@mccare
Copy link

mccare commented Jan 29, 2019

Describe the bug
The simple slider demo just displays boxes, no slides

To Reproduce
vue-cli 3.3.0

vue create slider
cd slider
npm install hooper
edit HelloWorld.vue and replace most of the template with

   <hooper>
      <slide>
        1
      </slide>
     <slide>
        2
      </slide>
     <slide>
        3
      </slide>
     <slide>
        4
      </slide>
    </hooper>

(and add the import and component stuff for Hooper and Slide)

Expected behavior
I would expect to see one "slide" with one number and that I could then scroll through the rest of the slides.

Screenshots
screenshot 2019-01-29 at 20 09 18

Desktop (please complete the following information):

  • OS: macOS 10.14.2
  • Browser Chrome
  • Version 71

Additional context
I've tried the demo, too, but same behaviour. Don't know what I'm missing...

@ismail9k
Copy link
Contributor

For your problem, I think you need to include the stylesheet file (hoopoe.css), and everything will work just fine.

@ismail9k ismail9k added the docs label Jan 29, 2019
@mccare
Copy link
Author

mccare commented Jan 30, 2019

Yes, got it! I've created a very small PR to fix this in the docs.
Btw, the standard vue-cli template will have

li { margin: 0 10px }

in the style section (for the HelloWorld.vue). This then produces a slider that 'moves to the right' on each slide since the elements on the left still have some space (the margin namely) and hooper uses the li element for slider. Maybe clear the li elements in hooper.css of formatting so no side effects of existing formating will be there?

@mccare mccare closed this as completed Jan 30, 2019
ismail9k pushed a commit that referenced this issue Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants