Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(attachments): use proper attribute to retrieve URLs #286

Merged
merged 2 commits into from
Nov 19, 2023

Conversation

delphiki
Copy link
Contributor

I have done all the following:

  • added the feature
  • added documentation for the feature
  • added tests for the feature
  • ran mypy, black, and unit tests

Attachments of type "URL" follow this schema (at least on the Pronote version used by the school of my kids):

"ListePieceJointe": {
  "_T": 24,
  "V": [
    {
      "N": "XXXXXXXXXX",
      "G": 0,
      "url": "https://digipad.app/p/393............"
    },
    {
      "L": "Cours Nuit et Brouillard 2023.pdf",
      "N": "XXXXXXXXXX",
      "G": 1
    },
    {
      "L": "Fiche Nuit et Brouillard.pdf",
      "N": "XXXXXXXXXX",
      "G": 1
    }
  ]
}

pronotepy/dataClasses.py Outdated Show resolved Hide resolved
@bain3 bain3 merged commit 6414888 into bain3:master Nov 19, 2023
3 checks passed
@delphiki
Copy link
Contributor Author

Merci pour tes corrections :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants