Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add other absence #292

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add other absence #292

wants to merge 1 commit into from

Conversation

SLMitch
Copy link

@SLMitch SLMitch commented Jan 22, 2024

Hi,

I notice on my client interface that I have some "absences" not yet classified in current categories (no absence, no punishment).

It is under "Défauts de carnet/carte."

I am adding an "OtherAbsence" class, only with a name, in order to create a "sandbox" for absences. Maybe someone will create other classes with more detail, but my classes can be used to sort "other categories" of absences.

Regards

@tarneaux
Copy link
Contributor

tarneaux commented Jan 24, 2024

I don't think this should be the way to do it: I'd prefer having a dataclass that describes absences, with an attribute telling the type (of which an unknown one) and another with the full category name given by Pronote.

Edit: looks like we already have Absence.reasons of type List[str]. I'm not sure what you mean with "classified in current categories". To me absences aren't classified in pronotepy, am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants