fix Bordeaux ENT #296
Merged
fix Bordeaux ENT #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HubEduConnect method requires the Pronote URL to be passed. This URL is passed when creating or refreshing the client instance. In this commit, the URL is not used in any ENT function. All ENT functions are made more flexible by accepting optional keyword arguments (kwargs).
It was required to call pronote_hubeduconnect() with the Pronote URL as argument when creating the client. It is now moved with other ENTs, getting the additional parameter "pronote_url" automatically.
Several ENTs are processing SAML request/response. Make it a single function used by the ENTs.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
L'académie de Bordeaux utilise HubEduConnect.