Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use labels for process state #5

Merged
merged 1 commit into from
Jul 28, 2017
Merged

Use labels for process state #5

merged 1 commit into from
Jul 28, 2017

Conversation

bakins
Copy link
Owner

@bakins bakins commented Jul 28, 2017

see #4

Also includes some minor cleanup.

Sample output:

# HELP phpfpm_processes_total process count
# TYPE phpfpm_processes_total gauge
phpfpm_processes_total{state="active"} 1
phpfpm_processes_total{state="idle"} 4

@bakins bakins mentioned this pull request Jul 28, 2017
Closed
andrewhowdencom
andrewhowdencom approved these changes Jul 28, 2017
View reviewed changes
Copy link
Contributor

@andrewhowdencom andrewhowdencom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicee! This is wicked.

README.md
@@ -38,7 +38,7 @@ Usage:

Flags:
--addr string listen address for metrics handler (default "127.0.0.1:8080")
--endpoint string address of driveshaft (default "http://127.0.0.1:9000/status")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol i missed this

@bakins bakins merged commit 4e10095 into master Jul 28, 2017
@bakins bakins deleted the process-labels branch July 28, 2017 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewhowdencom andrewhowdencom andrewhowdencom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bakins @andrewhowdencom