Deps: Replace request devDependency with @sailshq/request (#7339)

* Update package.json

* Update package.json

* update tests to use @sailshq/request

package.json

@@ -79,7 +79,7 @@
     "mocha": "3.0.2",
     "nunjucks": "3.0.1",
     "portfinder": "1.0.13",
-    "request": "2.83.0",
+    "@sailshq/request": "2.88.3",
     "root-require": "0.3.1",
     "sails-hook-orm": "^4.0.2",
     "sails-hook-sockets": "^3.0.0",

test/benchmarks/sails.request.generic.test.js

@@ -6,7 +6,7 @@ var util = require('util');
 var assert = require('assert');
 var tmp = require('tmp');
 var _ = require('@sailshq/lodash');
-var request = require('request');
+var request = require('@sailshq/request');
 
 var Filesystem = require('machinepack-fs');
 

test/helpers/test-spawning-sails-child-process-in-cwd.js

@@ -4,7 +4,7 @@
 
 var path = require('path');
 var _ = require('@sailshq/lodash');
-var request = require('request');
+var request = require('@sailshq/request');
 var MProcess = require('machinepack-process');
 
 

test/helpers/test-spawning-sails-lift-child-process-in-cwd.js

@@ -4,7 +4,7 @@
 
 var path = require('path');
 var _ = require('@sailshq/lodash');
-var request = require('request');
+var request = require('@sailshq/request');
 var MProcess = require('machinepack-process');
 var testSpawningSailsChildProcessInCwd = require('./test-spawning-sails-child-process-in-cwd');
 

test/hooks/http/initialize.test.js

@@ -6,7 +6,7 @@ var assert = require('assert');
 var util = require('util');
 var Sails = require('../../../lib').Sails;
 var $Router = require('../../helpers/router');
-var request = require('request');
+var request = require('@sailshq/request');
 
 describe('HTTP hook', function (){
 

test/hooks/views/skipAssets.test.js

@@ -6,7 +6,7 @@ var path = require('path');
 var util = require('util');
 var _ = require('@sailshq/lodash');
 var tmp = require('tmp');
-var request = require('request');
+var request = require('@sailshq/request');
 var MProcess = require('machinepack-process');
 var MFilesystem = require('machinepack-fs');
 var testSpawningSailsLiftChildProcessInCwd = require('../../helpers/test-spawning-sails-lift-child-process-in-cwd');

test/integration/helpers/httpHelper.js

@@ -1,4 +1,4 @@
-var request = require('request');
+var request = require('@sailshq/request');
 var fs = require('fs');
 
 

test/integration/lift.https.test.js

@@ -1,6 +1,6 @@
 var assert = require('assert');
 var fs = require('fs');
-var request = require('request');
+var request = require('@sailshq/request');
 var appHelper = require('./helpers/appHelper');
 var path = require('path');
 

test/integration/lift.test.js

@@ -5,7 +5,7 @@
 var path = require('path');
 var util = require('util');
 var tmp = require('tmp');
-var request = require('request');
+var request = require('@sailshq/request');
 var assert = require('assert');
 var _ = require('@sailshq/lodash');
 var MProcess = require('machinepack-process');

test/integration/middleware.404.test.js

@@ -1,9 +1,9 @@
 var _ = require('@sailshq/lodash');
-var request = require('request');
+var request = require('@sailshq/request');
 var Sails = require('../../lib').Sails;
 var assert = require('assert');
 var fs = require('fs-extra');
-var request = require('request');
+var request = require('@sailshq/request');
 var appHelper = require('./helpers/appHelper');
 var path = require('path');
 

test/integration/middleware.500.test.js

@@ -1,9 +1,9 @@
 var _ = require('@sailshq/lodash');
-var request = require('request');
+var request = require('@sailshq/request');
 var Sails = require('../../lib').Sails;
 var assert = require('assert');
 var fs = require('fs-extra');
-var request = require('request');
+var request = require('@sailshq/request');
 var appHelper = require('./helpers/appHelper');
 var path = require('path');
 

test/integration/middleware.compression.test.js

@@ -1,5 +1,5 @@
 var _ = require('@sailshq/lodash');
-var request = require('request');
+var request = require('@sailshq/request');
 var Sails = require('../../lib').Sails;
 var assert = require('assert');
 

test/integration/middleware.cookieParser.test.js

@@ -3,7 +3,7 @@
  */
 
 var _ = require('@sailshq/lodash');
-var request = require('request');
+var request = require('@sailshq/request');
 var Sails = require('../../lib').Sails;
 var assert = require('assert');
 

test/integration/middleware.favicon.test.js

@@ -1,9 +1,9 @@
 var _ = require('@sailshq/lodash');
-var request = require('request');
+var request = require('@sailshq/request');
 var Sails = require('../../lib').Sails;
 var assert = require('assert');
 var fs = require('fs-extra');
-var request = require('request');
+var request = require('@sailshq/request');
 var appHelper = require('./helpers/appHelper');
 var path = require('path');
 

test/integration/middleware.handleBodyParserError.test.js

@@ -1,9 +1,9 @@
 var _ = require('@sailshq/lodash');
-var request = require('request');
+var request = require('@sailshq/request');
 var Sails = require('../../lib').Sails;
 var assert = require('assert');
 var fs = require('fs-extra');
-var request = require('request');
+var request = require('@sailshq/request');
 var appHelper = require('./helpers/appHelper');
 var path = require('path');
 

test/integration/middleware.sails.test.js

@@ -2,7 +2,7 @@
  * Module dependencies
  */
 
-var request = require('request');
+var request = require('@sailshq/request');
 var Sails = require('../../lib').Sails;
 var assert = require('assert');
 

test/integration/middleware.session.redis.test.js

@@ -1,5 +1,5 @@
 var _ = require('@sailshq/lodash');
-var request = require('request');
+var request = require('@sailshq/request');
 var Sails = require('../../lib').Sails;
 var assert = require('assert');
 var cookie = require('cookie');

test/integration/middleware.session.test.js

@@ -1,5 +1,5 @@
 var _ = require('@sailshq/lodash');
-var request = require('request');
+var request = require('@sailshq/request');
 var Sails = require('../../lib').Sails;
 var assert = require('assert');
 var cookie = require('cookie');

test/integration/middleware.startRequestTimer.test.js

@@ -1,9 +1,9 @@
 var _ = require('@sailshq/lodash');
-var request = require('request');
+var request = require('@sailshq/request');
 var Sails = require('../../lib').Sails;
 var assert = require('assert');
 var fs = require('fs-extra');
-var request = require('request');
+var request = require('@sailshq/request');
 var appHelper = require('./helpers/appHelper');
 var path = require('path');
 

test/integration/middleware.static.test.js

@@ -3,11 +3,11 @@
  */
 
 var _ = require('@sailshq/lodash');
-var request = require('request');
+var request = require('@sailshq/request');
 var Sails = require('../../lib').Sails;
 var assert = require('assert');
 var fs = require('fs-extra');
-var request = require('request');
+var request = require('@sailshq/request');
 var appHelper = require('./helpers/appHelper');
 var path = require('path');