Redis sessions with custom prefix include the prefix twice in the key

[travispwingo]

Node version: 8.15
Sails version (sails): 1.2.2
ORM hook version _(sails-hook-orm): 2.1.1
Sockets hook version (sails-hook-sockets): 1.5.5
Grunt hook version (sails-hook-grunt): 1.0.8
DB adapter & version (e.g. sails-mysql@5.55.5): sails-postgresql@1.0.2
connect-redis version: sailshq/connect-redis@3.2.1

---

Within our config:session.js file, we have defined a custom prefix for our redis key as such.

module.exports.session = {
  prefix: ‘foo:’
  ...
};

When we initialize a new session, the key being stored in redis is actually “foo:foo:key_value_here.”

While this is fine for a single app, we share a session between multiple applications, so the session is immediately replaced by another sails app who’s looking for “foo:key_value_here” and is not finding it.

[sailsbot]

@travispwingo Thanks for posting! We'll take a look as soon as possible.

In the mean time, there are a few ways you can help speed things along:

• look for a workaround. (Even if it's just temporary, sharing your solution can save someone else a lot of time and effort.)
• tell us why this issue is important to you and your team. What are you trying to accomplish? (Submissions with a little bit of human context tend to be easier to understand and faster to resolve.)
• make sure you've provided clear instructions on how to reproduce the bug from a clean install.
• double-check that you've provided all of the requested version and dependency information. (Some of this info might seem irrelevant at first, like which database adapter you're using, but we ask that you include it anyway. Oftentimes an issue is caused by a confluence of unexpected factors, and it can save everybody a ton of time to know all the details up front.)
• read the code of conduct.
• if appropriate, ask your business to sponsor your issue. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
• let us know if you are using a 3rd party plugin; whether that's a database adapter, a non-standard view engine, or any other dependency maintained by someone other than our core team. (Besides the name of the 3rd party package, it helps to include the exact version you're using. If you're unsure, check out this list of all the core packages we maintain.)

---

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

[johnabrams7]

@travispwingo I was able to reproduce the prefix duplicate on the redis session key as well (tried some variations with spacing):

Currently looking into potential solutions or workarounds.

Also wanted to note the stylized single quotes on prefix: ‘foo:’ in the example would cause a different issue:

[travispwingo]

Cool good to know. I just submitted a pr that fixes the issue for me. I hope I didn’t miss anything! #6543

…

On May 31, 2019, at 11:37 AM, johnabrams7 ***@***.***> wrote: @travispwingo <https://github.com/travispwingo> I was able to reproduce the prefix duplicate on the redis session key as well: <https://user-images.githubusercontent.com/32274602/58726931-a22b4580-83a8-11e9-92c7-c8b75aac234b.png> Currently looking into potential solutions or workarounds. Also, I wanted to note the stylized single quotes on prefix: ‘foo:’ in the example code would cause a different issue: <https://user-images.githubusercontent.com/32274602/58727154-24b40500-83a9-11e9-8624-b4dea7029d22.png> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6541?email_source=notifications&email_token=AA2LEWPM23B5VVYGWQJYHGDPYFV7TA5CNFSM4HRNR2E2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWWBO7Y#issuecomment-497817471>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA2LEWOUNWZMAW2BKSM754TPYFV7TANCNFSM4HRNR2EQ>.

[johnabrams7]

@travispwingo Fantastic! Just saw the PR. Will bring it up with the team 👍

[agsantos]

Hi,

Any update on this issue?

[johnabrams7]

@agsantos @travispwingo PR Fix confirmed working & merged. Will be included in a sails update shortly.