Allows keeping response errors in production mode with sails.config.keepResponseErrors #2853
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMHO the current behavior in response handlers of clearing the body in production mode should be optional, hence the proposed
sails.config.keepResponseErrors
here.Consider the case of a waterline validation error from a model backing a REST operation, one could return a 400 with a list of validation failures:
The docs here for
res.badRequest()
say "For requesters expecting JSON, this response includes the 400 status code and any relevant data sent as validationErrors." Well, this isn't true -- in production mode response body is cleared regardless ofreq.wantsJSON
.Thoughts?