Update hook.cors_csrf unit test to be compliant with node 4.x.x #3322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @AlexisNo. We ended up opting for an approach that mimics the underlying |
ctartist621
pushed a commit
to ctartist621/sails
that referenced
this pull request
Feb 3, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit test suite didn't pass with node 4.x.x. The MKCALENDAR http method is now supported but the test was checking the response of an OPTION request globally.
In this PR, I checked the presence of each http method that should be available for node < 4.x.x.
MKCALENDAR is not tested, but the test suite works successfully with 4.x.x .