Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n module is updated #3631

Merged
merged 5 commits into from
Mar 30, 2016
Merged

i18n module is updated #3631

merged 5 commits into from
Mar 30, 2016

Conversation

dangreen
Copy link
Contributor

@dangreen dangreen commented Mar 2, 2016

No description provided.

@sgress454
Copy link
Member

From #3611:

i18n 0.7.0 (and the new 0.8.0) causes the Sails tests to fail. That's pretty disturbing.

0.6.0 seems to work alright, but I'm holding off for the moment. It's possible that the tests failing with 0.7.0 is due to an issue in Sails core, not in i18n; either way, someone needs a patch.

@dangreen
Copy link
Contributor Author

dangreen commented Mar 2, 2016

@sgress454 okay, i want fix it.
Tests fails with this error ?

  1 failing

  1) API and adapter generators "before all" hook:
     Uncaught Error: ENOENT: no such file or directory, uv_chdir
      at Error (native)
      at process.chdir (node_modules/fs-extra/node_modules/graceful-fs/polyfills.js:14:9)
      at test/integration/generate.test.js:29:15
      at ChildProcess.exithandler (child_process.js:204:7)
      at maybeClose (internal/child_process.js:821:16)
      at Socket.<anonymous> (internal/child_process.js:319:11)
      at Pipe._onclose (net.js:469:12)

@dangreen
Copy link
Contributor Author

dangreen commented Mar 2, 2016

@sgress454 can you say exact tests which fails with i18n@0.8.0?

@sgress454
Copy link
Member

@dangreen You can see the failing tests on Travis; they fail the same way for me locally.

@dangreen
Copy link
Contributor Author

dangreen commented Mar 2, 2016

@mashpie
Copy link

mashpie commented Mar 3, 2016

merged - about to release as hotfix 0.8.1

@mashpie
Copy link

mashpie commented Mar 3, 2016

ok released to npm - I was thinking of adding sails to QA... time to do so :)

@dangreen
Copy link
Contributor Author

dangreen commented Mar 3, 2016

@mashpie Thank you for very useful lib!)

@mashpie
Copy link

mashpie commented Mar 3, 2016

Thank you for patching :)

@dangreen
Copy link
Contributor Author

dangreen commented Mar 5, 2016

@sgress454 what about merge ?

@sgress454
Copy link
Member

Thanks for staying on top of this, I'll check it out ASAP!

@dangreen
Copy link
Contributor Author

@sgress454 ?

@sgress454 sgress454 merged commit 560fe31 into balderdashy:master Mar 30, 2016
@sgress454
Copy link
Member

Thanks @dangreen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants