Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying whether to unconditionally kill containers, or first send SIGTERM #49

Open
CameronDiver opened this issue Sep 13, 2019 · 3 comments

Comments

@CameronDiver
Copy link
Contributor

context: balena-os/balena-supervisor#1079

Currently livepush will always send a SIGKILL to restart the container, for speed, but some applications require being able to catch a signal to clean up before exiting. This should just be an option which says either kill first, otherwise use docker stop to respectfully wait for the container to finish.

@balena-ci
Copy link
Contributor

[karaxuna] This issue has attached support thread https://jel.ly.fish/#/support-thread~692cfd3b-8303-4383-9dc4-7c528cb198f8

@hpgmiskin
Copy link

Hi @CameronDiver, have there been any recent updates on this? I am not able to access Jellyfish and would really appreciate the ability for live push to allow the program to do a graceful shutdown.

@pdcastro
Copy link
Contributor

@hpgmiskin, I don't think there were any updates. I have created a balena CLI issue (balena-io/balena-cli#2162) to increase visibility of the problem - thanks for re-surfacing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants