Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

livepush: Allow specifying whether to unconditionally kill containers, or first send SIGTERM #2162

Open
pdcastro opened this issue Jan 18, 2021 · 0 comments
Open

livepush: Allow specifying whether to unconditionally kill containers, or first send SIGTERM #2162

pdcastro opened this issue Jan 18, 2021 · 0 comments
Labels
type:feature

Comments

@pdcastro
Copy link
Contributor

As originally reported in balena-io-modules/livepush/issues/49 - cloning here for additional visibility.

context: balena-os/balena-supervisor#1079
Currently livepush will always send a SIGKILL to restart the container, for speed, but some applications require being able to catch a signal to clean up before exiting. This should just be an option which says either kill first, otherwise use docker stop to respectfully wait for the container to finish.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pdcastro