Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Layout component #1690

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Add Layout component #1690

merged 1 commit into from
Feb 1, 2023

Conversation

myarmolinsky
Copy link
Contributor

Add Layout component

Change-type: minor


Contributor checklist
  • I have regenerated jest snapshots for any affected components with npm run generate-snapshots
Reviewer Guidelines
  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

@myarmolinsky myarmolinsky self-assigned this Jan 9, 2023
@myarmolinsky myarmolinsky force-pushed the add-layout-component branch 8 times, most recently from 8e00f5b to 2ccd2d5 Compare January 16, 2023 14:31
@myarmolinsky myarmolinsky force-pushed the add-layout-component branch 3 times, most recently from 90f57f3 to a188d62 Compare January 25, 2023 18:23
Change-type: minor
@myarmolinsky myarmolinsky marked this pull request as ready for review February 1, 2023 19:55
@myarmolinsky
Copy link
Contributor Author

LGTM

@myarmolinsky myarmolinsky merged commit 339f269 into master Feb 1, 2023
@myarmolinsky myarmolinsky deleted the add-layout-component branch February 1, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants