Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout: Fix ErrorBoundary property typing #1696

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

myarmolinsky
Copy link
Contributor

@myarmolinsky myarmolinsky commented Feb 6, 2023

Layout: Fix ErrorBoundary property typing

Change-type: patch


Contributor checklist
  • I have regenerated jest snapshots for any affected components with npm run generate-snapshots
Reviewer Guidelines
  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

@myarmolinsky myarmolinsky marked this pull request as ready for review February 7, 2023 15:48
@myarmolinsky myarmolinsky changed the title Layout: Fix flickering effect Layout: Fix ErrorBoundary typing Feb 7, 2023
@myarmolinsky myarmolinsky changed the title Layout: Fix ErrorBoundary typing Layout: Fix ErrorBoundary property typing Feb 7, 2023
@myarmolinsky
Copy link
Contributor Author

LGTM

@myarmolinsky myarmolinsky merged commit 478f5e2 into master Feb 7, 2023
@myarmolinsky myarmolinsky deleted the fix-flickering-effect branch February 7, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant