-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to the v7 model #1420
Update to the v7 model #1420
Conversation
f128e4b
to
926a515
Compare
@@ -81,13 +76,6 @@ export interface OsVersion | |||
basedOnVersion?: string; | |||
osType: string; | |||
line?: OsLines; | |||
/** @deprecated */ | |||
isRecommended?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would reimplement it back as we discussed last time. This will keep the logic centralised and avoid having to replicate the "isRecommended" method in parts that uses it.
6ff059f
to
4932a1c
Compare
6ec4a6f
to
48facf7
Compare
testing it I've noticed that now we cannot make any requests without passing at least a $select, is this wanted ?
|
@JSReds are you using When I tested the sdk against v7 on my bM last weekend, the tests cases passed as they are (w/o adding the missing |
got it @thgreasi, I'm effectively using |
I've just added test cases to make sure v7 works w/o $selects as well in the API PR :) |
…he current latest Change-type: major
Update pinejs-client-core from 6.14.0 to 6.15.0 Change-type: patch
Change-type: patch
Change-type: major
…ameters Change-type: major
Change-type: major
Change-type: minor
Change-type: major
Change-type: major
Change-type: major
… typings Change-type: major
Change-type: major
…erties Change-type: major
…h should_be_managed_by__release Change-type: major
Change-type: major
Change-type: minor
…d_on__release Change-type: major
…nned_to__device Change-type: major
…ed property when selected Change-type: major
…ted, reduced-functionality & operational Change-type: major
Change-type: patch
Change-type: patch
Change-type: patch
Change-type: patch
Change-type: major
See: https://balena.fibery.io/Work/Project/Server-side-pagination-for-devices-Cycle-3-539