-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi_dockerignore option #249
Add multi_dockerignore option #249
Conversation
@thgreasi can I get a review? |
c81aab6
to
45688c0
Compare
45688c0
to
f11ac92
Compare
@@ -55,6 +55,10 @@ inputs: | |||
description: Branch for finalizing releases | |||
required: false | |||
default: "" | |||
multi_dockerignore: | |||
description: Use service's dockerignore file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@karaxuna after enabling external contributors, I now see a different error in CI
See: https://github.com/balena-io/deploy-to-balena-action/actions/runs/4505762867/jobs/7932156158#step:4:95
Can you try removing this '
and see whether that fixes the yml?
The issue here is that this secondary job deploy-to-balena-action/.github/workflows/flowzone.yml Lines 30 to 51 in 72464a1
Was not designed with |
Change-type: minor
f11ac92
to
db2cede
Compare
Thanks for the PR @karaxuna and sorry for the delay on reviewing (and extending flowzone to allow external contributor PRs). |
This change adds an option to use the --debug flag to the Balena push command to allow to see debug build logs. This PR has been modeled after a similar PR to add the --multi-dockerignore flag [here](balena-io#249)
Change-type: minor This change adds an option to use the --debug flag to the Balena push command to allow to see debug build logs. This PR has been modeled after a similar PR to add the --multi-dockerignore flag [here](balena-io#249)
Change-type: minor This change adds an option to use the --note flag to the Balena push command to add a note to the release This PR has been modeled after a similar PR to add the --multi-dockerignore flag [here](balena-io#249)
This change adds an option to use the --note flag to the Balena push command to add a note to the release This PR has been modeled after a similar PR to add the --multi-dockerignore flag [here](balena-io#249) Change-type: minor
Change-type: minor