Skip to content

Commit

Permalink
chore: enforce single quotes in ESLint (#1679)
Browse files Browse the repository at this point in the history
We recently adopted the standardjs guidelines ESLint, which doesn't seem
to enforce single quotes, even though the guidelines mention it.

See: #1663 (comment)
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
  • Loading branch information
jviotti authored Aug 8, 2017
1 parent b97d708 commit 79a7a03
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions .eslintrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,9 @@ rules:
operator-assignment:
- error
- always
quotes:
- error
- single
quote-props:
- error
- as-needed
Expand Down
2 changes: 1 addition & 1 deletion tests/gui/components/svg-icon.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ describe('Browser: SVGIcon', function () {
it('should use an empty src if there is a parsererror', function () {
// The following is invalid, because there's no closing tag for `foreignObject`
const iconContents = '<svg><foreignObject></svg>'
const imgData = `data:image/svg+xml,`
const imgData = 'data:image/svg+xml,'
$rootScope.iconContents = iconContents

const element = $compile('<svg-icon path="iconContents">Resin.io</svg-icon>')($rootScope)
Expand Down

0 comments on commit 79a7a03

Please sign in to comment.