Build and package ARM releases

[ab77]

Dependencies:

• Update dependencies balena-io-modules/etcher-sdk#267

Showstoppers

• https://github.com/balena-io/etcher/pull/3896/files#diff-1e6a5ce8ae6f024f8d6a5e3443a05f0921f3f5aa0c789b816349b4c148638e4aR10-R18

Showstoppers (windows-arm64):

• Add support for Windows ARM64 addaleax/lzma-native#132
  https://github.com/RockLakeGrass/lzma-native-Windows-ARM64/blob/42be008b8a657eae4a9506a90b96fec3e86d5582/package.json
• Re-add Windows arm64 (un)official builds nodejs/build#2450 (comment)
• Add ARM64 Windows environment actions/runner-images#768
• https://github.blog/changelog/2022-09-28-github-actions-self-hosted-runners-now-support-windows-arm-hardware/

[aethernet]

@ab77 i had no issue building direct-io for arm64 on my m1 with node-gyp, are we trying to cross-compile here ?

[ab77]

@ab77 i had no issue building direct-io for arm64 on my m1 with node-gyp, are we trying to cross-compile here ?

Yes, cross compiling. No native ARM hardware available in this context.

[thedocbwarren]

Does this build with an DMG now? I've been able to build the code but no DMG is made. I can publish a community build if a DMG is built.

[ab77]

Does this build with an DMG now? I've been able to build the code but no DMG is made. I can publish a community build if a DMG is built.

unfortunately not, see #3896 (comment)

[mcraa]

We had the ext2fs error in previous PRs and should be solved on master already, I don't know why is it coming back here.
The node-gyp error on windows is new for me, found quite some issues mentioning it for example
nodejs/node-gyp#1371

[ab77]

We had the ext2fs error in previous PRs and should be solved on master already, I don't know why is it coming back here.

workaround by setting strict: false. The real fix is to maybe figure out why a replacement isn't being made?

The node-gyp error on windows is new for me, found quite some issues mentioning it for example nodejs/node-gyp#1371

Maybe because we are trying to bundle drivelist v9.2.x, which is ~ 2-4 years old and build/re-build under node 16?

[mcraa]

We had the ext2fs error in previous PRs and should be solved on master already, I don't know why is it coming back here.

workaround by setting strict: false. The real fix is to maybe figure out why a replacement isn't being made?

to remove the reliance on node stuff like binding and the node_modules folder which are not available in the packaged electron environment

The node-gyp error on windows is new for me, found quite some issues mentioning it for example nodejs/node-gyp#1371

Maybe because we are trying to bundle drivelist v9.2.x, which is ~ 2-4 years old and build/re-build under node 16?

then it should fail on the other two platforms too

[ab77]

then it should fail on the other two platforms too

Sure, it should, but it doesn't. Maybe Windows is special. Maybe trying to build code years out of date with modern tools is the problem. Maybe both - I have no idea. I am ignoring this issue for now and hoping by the time I cycle back to it, all the dependencies are bumped up and it just builds.

[ab77]

to remove the reliance on node stuff like binding and the node_modules folder which are not available in the packaged electron environment

I am afraid I don't understand what that means. One problem I found is that fetchWasm() throws an error with with string-replace-loader { strict: true }. I've not dug into it, but from reading the docs, this would happen if no replacement is made, so to catch no-ops I am guessing.

[mcraa]

Add cross-env or similar instead of bash.
On line 17 flowzone-preinstall-linux still has electron-builder.yml but that file is removed.

[ab77]

Add cross-env or similar instead of bash.
https://github.com/kentcdodds/cross-env is archived and the package is not gettign any support. Do we really need to use it? My preference would be not to include depracated packages if at all possible, give we already have a ton of those. what does cross-env give us over bash, if bash is standardised across platforms?

On line 17 flowzone-preinstall-linux still has electron-builder.yml but that file is removed.
Cheers, fixed.

[mcraa]

That is why I wrote "cross-env or similar"
however from the author:

So I'm declaring cross-env as finished. No new features will be added (and old features will not likely be removed). I don't plan to do any more than fix security/critical bugs and keep the Node.js support up-to-date.

It still looks like a safe bet.
bash is not available out of the box on many platforms, with a package like this we don't need to write if windows then cmd if linux then bash but only if not zsh, etc and so when a new contributor tries to run npm i it will just run even if they don't have bash.

[ab77]

I am 100% against this mate, mostly for ideological reasons of not introducing any more deprecated packages. Surely we can have a maintainer guide that says "you must install {{shell}} to work on this project".

[dfunckt]

Superseded by #4132